Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed symbol zip file not being moved with Unity 2022, include non-batch mode build support. #239

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

trapezoid
Copy link
Contributor

Applied change #226 to address an issue in Unity 2022.1 and later where symbol files were no longer being moved correctly because they now include the name of the scripting backend in the symbol file name.

At that time, Fixed a bug that caused an exception to be thrown when executing a build in non-batch mode because PlayerSettings.GetScriptingBackend was accessed from outside the main thread.

Copy link

google-cla bot commented Feb 19, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@trapezoid
Copy link
Contributor Author

@google-admin

CLA check is already passed.

https://github.com/google/play-unity-plugins/pull/239/checks

Unless this PR is incorporated, I am unable to resolve symbol names in crash reports for applications built with play-unity-plugins in Unity 2022.
We would be grateful if you could confirm this for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant